Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Extension icons for dark/light mode #208

Open
daimor opened this issue Aug 10, 2022 · 0 comments
Open

Separate Extension icons for dark/light mode #208

daimor opened this issue Aug 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@daimor
Copy link

daimor commented Aug 10, 2022

Is your feature request related to a problem? Please describe.
Yeah, some of the icons, may look good on a light theme, but a dark theme may require some changes in colors.

Describe the solution you'd like
add an ability to define different icons in metadata.json

{
  "icon": "compny-logo.svg"
}

Additionally support for something like this, but keep previous supported

{
  "icon": {
    "dark": "compny-logo-dark.svg",
    "light": "compny-logo-light.svg"
  }
}

I did not get when used labels from Dockerfile, and not sure if it would even need there
com.docker.desktop.extension.icon=
com.docker.desktop.extension.icon.light=
com.docker.desktop.extension.icon.dark=

@daimor daimor added the enhancement New feature or request label Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant