Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2 yaml validator doesn't catch duplicated ignore: sections. #1919

Open
georgedorn opened this issue Jun 18, 2020 · 2 comments
Open
Labels
F: configuration-file F: dependency-ignores Allow excluding certain versions T: bug 🐞 Something isn't working

Comments

@georgedorn
Copy link

georgedorn commented Jun 18, 2020

This validates:

version: 2
updates:
- package-ecosystem: pip
  directory: "/"
  schedule:
    interval: daily
    time: '13:00'
  open-pull-requests-limit: 10
  ignore:
  - dependency-name: chromedriver-binary
  ignore:
  - dependency-name: celery
  commit-message:
    prefix: chore

But then dependabot happily opens PRs to update chromedriver-binary, as the second ignore: clobbers the first.

(I'm now aware of the correct format; this bug report is because the validator didn't catch this. Also, maybe somebody else searching for why dependabot isn't respecting their 'ignore' statements will find this, too.)

@georgedorn georgedorn added the T: bug 🐞 Something isn't working label Jun 18, 2020
@feelepxyz
Copy link
Contributor

@georgedorn thanks for reporting! We'll look into handling this better. Suprised our JSON schema validation doesn't pick this up.

@jeffwidman jeffwidman added the F: dependency-ignores Allow excluding certain versions label Feb 5, 2023
@jeffwidman jeffwidman changed the title Version 2 yaml validator doesn't catch duplicated 'ignore:' sections. Version 2 yaml validator doesn't catch duplicated ignore: sections. Feb 6, 2023
Copy link
Contributor

github-actions bot commented Feb 6, 2025

👋 This issue has been marked as stale because it has been open for 2 years with no activity. You can comment on the issue to hold stalebot off for a while, or do nothing. If you do nothing, this issue will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details.

@github-actions github-actions bot added the Stale label Feb 6, 2025
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 14, 2025
@abdulapopoola abdulapopoola reopened this Feb 14, 2025
@github-actions github-actions bot removed the Stale label Feb 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: configuration-file F: dependency-ignores Allow excluding certain versions T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants