riscv64: Add minimal support for the Zfa Extension #8536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds support for the Zfa extension and implements the `fminm`/`fmaxm` instructions and lowerings. The Zfa extension provides additional floating point related instructions not included in either F/D extensions.
afonso360
added
the
cranelift:area:riscv64
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:riscv64", "cranelift:meta", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This PR adds initial support for the Zfa extension and implements the
fminm/fmaxminstructions and lowerings.The Zfa extension provides additional floating point related instructions not included in either F/D extensions. Here's a link to version 1 of the extension if anyone feels up to some light reading.
The
f{min,max}minstructions implemented in this PR are pretty much the same as the basefmin/fmaxpresent in the ISA, but they have different NaN behavior, that conveniently matches the semantics of Cranelift'sfmin/fmaxinstructions, allowing for a more efficient lowering.