Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machete doesn't support resolver = "3" #144

Closed
AMDmi3 opened this issue Dec 19, 2024 · 8 comments
Closed

Machete doesn't support resolver = "3" #144

AMDmi3 opened this issue Dec 19, 2024 · 8 comments

Comments

@AMDmi3
Copy link
Contributor

AMDmi3 commented Dec 19, 2024

% cargo machete                                                                                                                                                                                                                                                                1
Analyzing dependencies of crates in this directory...
error when handling ./Cargo.toml: TOML parse error at line 3, column 12
  |
3 | resolver = "3"
  |            ^^^
unknown variant `3`, expected `1` or `2`

this is a valid variant for nightly though (and default for rust 2024 if I'm not mistaken).

@bnjbvr
Copy link
Owner

bnjbvr commented Dec 21, 2024

Thanks for opening an issue! It's probably a matter of upgrading one of the dependencies parsing the cargo.toml, so likely an easy patch. Would you like to contribute it? :)

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Dec 23, 2024

Sure, #145

@bnjbvr bnjbvr closed this as completed in 2ac2f4c Jan 6, 2025
@bnjbvr bnjbvr marked this as a duplicate of #150 Jan 29, 2025
@orium
Copy link

orium commented Feb 24, 2025

@bnjbvr Any chance we can get a release of cargo-machete with this fix? This is a problem I'm facing now that edition 2024 was released.

@bnjbvr
Copy link
Owner

bnjbvr commented Feb 24, 2025

Yep, will try to do it later today, thanks for the ping!

@bnjbvr
Copy link
Owner

bnjbvr commented Feb 24, 2025

And done!

@orium
Copy link

orium commented Feb 24, 2025

I'm not seeing it in crates.io.

@bnjbvr
Copy link
Owner

bnjbvr commented Feb 25, 2025

Oops, should be better now.

@orium
Copy link

orium commented Feb 25, 2025

Awesome. Thanks for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants