Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📎 Extend plugin support to CSS files #4427

Closed
arendjr opened this issue Oct 29, 2024 · 1 comment
Closed

📎 Extend plugin support to CSS files #4427

arendjr opened this issue Oct 29, 2024 · 1 comment
Labels
A-Plugins Area: plugins L-CSS Language: CSS

Comments

@arendjr
Copy link
Contributor

arendjr commented Oct 29, 2024

Description

Currently, our GritQL plugins support running against JS/TS files. We should extend this to include CSS files as well.

It will require the implementation of a struct CsssTargetLanguage similar to the existing struct JsTargetLanguage. It will need to be registered in grit_target_language.rs, and we'll need to look for various places where JsTargetLanguage is currently being hard-coded.
@arendjr arendjr added L-CSS Language: CSS A-Plugins Area: plugins labels Oct 29, 2024
@arendjr
Copy link
Contributor Author

arendjr commented Nov 1, 2024

First part is addressed here: #4444

@arendjr arendjr mentioned this issue Nov 1, 2024
Merged
@arendjr arendjr closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Plugins Area: plugins L-CSS Language: CSS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arendjr