Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cover Art Archive request if thumbnail size doesn't exist #3638

Closed
mtrolley opened this issue Jun 27, 2020 · 1 comment
Closed

Fix Cover Art Archive request if thumbnail size doesn't exist #3638

mtrolley opened this issue Jun 27, 2020 · 1 comment

Comments

@mtrolley
Copy link
Contributor

mtrolley commented Jun 27, 2020

I introduced a change with PR#3637 to fetch the particular Cover Art Archive thumbnail image if the maxwidth option of fetchart is set to exactly one of the values the Cover Art Archive API exposes.

When testing it I tested with an album that had an original cover art with dimensions greater than the largest supported thumbnail, which is 1200px. That worked fine for that album, but I've now realised that if the original cover art size is less than 1200px then there will be no 1200px thumbnail image available to fetch.

To fix this I will make an additional change to ensure that the thumbnail exists, and fall back to the non-thumbnail URL if it does not.

@sampsyo
Copy link
Member

sampsyo commented Jun 27, 2020

Aha; makes sense! I merged the reversion PR—feel free to open a new one whenever you like.

@sampsyo sampsyo closed this as completed Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants