-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lyrics are wrong #2969
Comments
That’s certainly strange! The verbose output says:
But that seems wrong, since you clearly only have the google source enabled, not lyricswiki. I don’t know why the plugin doesn’t seem to be respecting your configuration there. I notice you seem to be on a pretty old version of beets (1.3.8). Have you tried using the most recent version? |
I installed via the Ubuntu repositories, so that's what version is there. I now installed via pip, and it's now version 1.4.7. I ran
The verbose output is much more helpful now. :) The url told me how to fix things, and running the command again succeeded:
What does "Bad triggers" mean? The lyrics are still wrong, so two of my questions from above still apply:
And now a new question:
|
Cool! I’m glad the sources issue has gone away in the current version. I don’t know what the “bad trigger” thing is meant to indicate—it seems to be part of the heuristic that decides whether a page actually contains lyrics. I’ll have to rely on @Kraymer to clarify his intent there.
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
In fact, it looks like this is due to a typo: The idea is to check whether the artist name occurs in the lyrics (which is unlikely, hence an indicator, that the plugin didn't scrape the actual lyrics). However, the typo means that the plugin never actually checks whether the artist name occurs in the text. The following patch should correct this. @Kraymer could you briefly check whether this is correct? diff --git a/beetsplug/lyrics.py b/beetsplug/lyrics.py
index f53191d8..1291f2a5 100644
--- a/beetsplug/lyrics.py
+++ b/beetsplug/lyrics.py
@@ -552,7 +552,7 @@ class Google(Backend):
bad_triggers = ['lyrics', 'copyright', 'property', 'links']
if artist:
- bad_triggers_occ += [artist]
+ bad_triggers += [artist]
for item in bad_triggers:
bad_triggers_occ += [item] * len(re.findall(r'\W%s\W' % item, This bug is quite old, is was introduced in 117d16f. |
@wisp3rwind yes your fix seems correct |
Closing this issue, it appears that the original issue with the google source was already resolved. If this wasn't the case, feel free to re-open and add some details, @Flurrywinde. |
Problem
I used all default values in my config file, and beets imported lyrics successfully. However, for Manowar's "Fast Taker", they were wrong, so I added the following to my config file (/home/kanon/.config/beets/config.yaml):
The same wrong lyrics appeared, despite google's regular search turning up different, better lyrics. (The first result in the "beets custom search engine" is different from both of these.)
Is there a way to tell which source beet is getting the lyrics from?
Also, is there a way to select which google source is used?
Is there a list of sources? For example, I see "lyrics.com" and "lyricwiki" on beets.readthedocs.io.
Running this command in verbose (
-vv
) mode:Led to this problem:
I notice it says: "google lyrics backend error: accessNotConfigured". Here is how I set up my google api key:

Is that correct? Why isn't it working?
Setup
My configuration (output of
beet config
) is:The text was updated successfully, but these errors were encountered: