Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable power assert #24

Closed
bcomnes opened this issue Oct 5, 2020 · 2 comments
Closed

Re-enable power assert #24

bcomnes opened this issue Oct 5, 2020 · 2 comments

Comments

@bcomnes
Copy link
Owner

bcomnes commented Oct 5, 2020

I couldn't (quickly) get power assert working while getting an initial release out this weekend. I did notice that, with it disabled, test output when encountering failure, is now absolutely terrible.

I don't think I like power assert very much now. Its proven laborious to keep working through updates, and when you turn it off your test failures become low quality.

3 options I see:

  • See if I can get it turned back on

    • Pros: get the intended test output back. less divergence from upstream.
    • cons: we have to decide to maintain troublesome and laborious babel toolchain maintenance. test environment has orders of magnitude more layers of complexity below it.
  • Keep it removed and have crappy test failure output

    • pros: simple. probably won't break. options for debugging still available when things go wrong.
    • cons: slightly divergent from upstream. bad test output.
  • Keep it power assert removed AND switch to a simpler assertion library

    • pros: better output and low complexity long term
    • cons: most divergent from upstream option. the way assertions are written might result in a costly change over to a different assertion lib. need to research this
@bcomnes
Copy link
Owner Author

bcomnes commented Feb 6, 2022

Feeling like any work in this direction should be towards tap. The timelines between this fork and upstream are wide enough at this point that they will unlikely get merged again.

@bcomnes
Copy link
Owner Author

bcomnes commented Jun 10, 2022

Nah, just change the assert style to include expected or whatever.

@bcomnes bcomnes closed this as completed Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant