-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): control library init version with a command-line parameter #149
Conversation
Allows controlling of the `cdk init` version of `aws-cdk-lib` using an environment variable. This will be used by tests.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
- Coverage 84.80% 84.53% -0.27%
==========================================
Files 198 198
Lines 35380 35400 +20
Branches 4572 4542 -30
==========================================
- Hits 30003 29926 -77
- Misses 5232 5329 +97
Partials 145 145
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just make this a cli feature? E.g. cdk init app --l typescript --version 2.123.0
Fair! Yeah, why not |
Signed-off-by: github-actions <[email protected]>
Allows controlling of the
cdk init
version ofaws-cdk-lib
:Mainly intended to be used by tests (to smoke-test that upcoming library versions still
init
properly), but it can be used by users as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license