Skip to content

Commit 2a2123f

Browse files
authored
ADM-1005 [frontend][backend]: fix e2e test in the buildkite and github (#1614)
* ADM-1005 [frontend]: fix the bug when pipeline settings exist in the redux but user select Other in the pipeline configuration * ADM-1005 [frontend]: fix test coverage * ADM-1005 [frontend][backend]: update the pipeline csv file * ADM-1005 [frontend][backend]: fix test * ADM-1005 [frontend]: fix e2e test * ADM-1005 [frontend]: add a test for with pipeline and source control configuration * ADM-1005 [frontend]: format * ADM-1005 [frontend]: format * ADM-1005 [frontend][backend]: fix e2e test in the buildkite and github
1 parent 48fb4b3 commit 2a2123f

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

.github/workflows/build-and-deploy.yml

+5
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,7 @@ jobs:
476476
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
477477
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
478478
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
479+
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
479480
E2E_PROJECT: "Google Chrome"
480481
shell: bash {0}
481482
run: ./ops/check.sh e2e
@@ -505,6 +506,7 @@ jobs:
505506
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
506507
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
507508
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
509+
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
508510
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
509511
shell: bash {0}
510512
run: ./ops/check.sh e2e
@@ -535,6 +537,7 @@ jobs:
535537
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
536538
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
537539
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
540+
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
538541
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
539542
shell: bash {0}
540543
run: ./ops/check.sh e2e
@@ -565,6 +568,7 @@ jobs:
565568
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
566569
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
567570
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
571+
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
568572
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
569573
shell: bash {0}
570574
run: ./ops/check.sh e2e
@@ -594,6 +598,7 @@ jobs:
594598
E2E_TOKEN_BUILD_KITE: ${{ secrets.E2E_TOKEN_BUILD_KITE }}
595599
E2E_TOKEN_GITHUB: ${{ secrets.E2E_TOKEN_GITHUB }}
596600
E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE: ${{ secrets.E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE }}
601+
E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL: ${{ secrets.E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL }}
597602
E2E_PROJECT: ${{ env.E2E_PLATFORM }}
598603
shell: bash {0}
599604
run: ./ops/check.sh e2e

ops/check.sh

+1
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ e2e_container_check() {
277277
-e "E2E_TOKEN_GITHUB=${E2E_TOKEN_GITHUB:-}" \
278278
-e "CI=${CI:-}" \
279279
-e "E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE=${E2E_TOKEN_PIPELINE_NO_ORG_CONFIG_BUILDKITE:-}" \
280+
-e "E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL=${E2E_TOKEN_GITHUB_WITH_OTHER_SOURCE_CONTROL:-}" \
280281
heartbeat_e2e:latest \
281282
pnpm run e2e:major-ci
282283
result=$?

0 commit comments

Comments
 (0)