Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about Sentence_Embedding #24

Open
Jabb0 opened this issue Jan 24, 2022 · 0 comments
Open

Question about Sentence_Embedding #24

Jabb0 opened this issue Jan 24, 2022 · 0 comments

Comments

@Jabb0
Copy link

Jabb0 commented Jan 24, 2022

Hi,
first of all thank you very much for sharing this!

I have two questions regarding the sentence embedding class.

  1. Why is th.no_grad() used with the embedding even if no pretrained embeddings are used?
  2. Does the model account for the zero padding in the text? E.g. by replacing the embeddings for padded words by zero before pooling.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant