Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt-kafka does not limit client sharding to mqtt v5 #708

Closed
jfallows opened this issue Jan 5, 2024 · 0 comments · Fixed by #760
Closed

mqtt-kafka does not limit client sharding to mqtt v5 #708

jfallows opened this issue Jan 5, 2024 · 0 comments · Fixed by #760
Assignees
Labels
bug Something isn't working

Comments

@jfallows
Copy link
Contributor

jfallows commented Jan 5, 2024

Describe the bug
When serverRef is specified in mqtt-kafka, this allows the mqtt-kafka binding to make use of kafka topic sharding and redirect clients to their zilla instance affinity, but mqtt v5 introduced the redirect capability so mqtt v3.1.1 clients cannot follow the redirect.

To Reproduce
Steps to reproduce the behavior:

  1. Use mqtt.kafka.broker in zilla-examples with multiple Zilla instances
  2. Ensure mqtt-sessions topic has multiple partitions
  3. Update zilla.yaml to specify serverRef in mqtt-kafka binding
  4. Connect with mqtt v3.1.1 client
  5. See error when not on affinity Zilla instance for client id

Expected behavior
When both mqtt v3.1.1 and mqtt v5 are supported, kafka topic sharding should be disabled.

Screenshots
None

Desktop (please complete the following information):
N/A

Smartphone (please complete the following information):
N/A

Additional context
None

@jfallows jfallows added the bug Something isn't working label Jan 5, 2024
@bmaidics bmaidics linked a pull request Jan 24, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants