Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade moduleResolution from node to node16 or nodenext in tsconfig #154

Open
caleblloyd opened this issue Feb 18, 2025 · 0 comments
Open

Upgrade moduleResolution from node to node16 or nodenext in tsconfig #154

caleblloyd opened this issue Feb 18, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@caleblloyd
Copy link

The tsconfig.json currently uses moduleResolution: node

languageservices/languageserver/tsconfig.json

Line 10 in bdee101

"moduleResolution": "node",

This should no longer be used in TypeScript:

It reflects the CommonJS module resolution algorithm as it existed in Node.js versions earlier than v12. It should no longer be used.

I think this is causing errors when importing as an NPM module from Deno, because imports should specify extensions, yet they do not with this module resolution

And the package.json specifies that this is an esmodule:

languageservices/languageservice/package.json

Line 6 in bdee101

"type": "module",

Consider moving it to node16 or nodenext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update module resolution to node16 caleblloyd/languageservices
1 participant
@caleblloyd