Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

form.validateAllFields became not work from 1.0.0 (regression) #1208

Open
viktor-galytskyi opened this issue Mar 3, 2025 · 3 comments
Open

Comments

@viktor-galytskyi
Copy link

Describe the bug

const validationErrors: ValidationError[] = await form.validateAllFields('submit');
return empty ValidationError array even if some fields are not valid.

in a screenshot, there are two places with "calculation[0].name" validation data.

  1. state.errors (error present)
  2. fieldMeta (no error, Why?)

Field "...name" is not valid, but fieldMeta without an error.

Image
  1. isFieldsValid: true but errors array not empty

Your minimal, reproducible example

code

Steps to reproduce

define form.
Make some fields not valid.
Trigger await form.handleSubmit();
Take a look at validationErrors: ValidationError[];

const handleSave = async (form) => {
await form.handleSubmit();

const validationErrors: ValidationError[] = await form.validateAllFields('submit');

console.log('form', form);

};

Expected behavior

  1. form.validateAllFields('submit'); should return errors
  2. fiealdMeta should be marked as not valid in the correspondent field
  3. isFieldsValid* should be false in case form fields not valid.

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

  • MacOS (last)
  • Chrome (last)

TanStack Form adapter

react-form

TanStack Form version

1.0.0

TypeScript version

No response

Additional context

No response

@crutchcorn
Copy link
Member

You mentioned this was a regression - from which version?

@viktor-galytskyi
Copy link
Author

@crutchcorn
0.41.0 was good

@crutchcorn
Copy link
Member

I can't reproduce this error. It's working for me. Please include a minimal reproduction error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants