Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Product] Thumbnails not updating the active media #3502

Closed
ludoboludo opened this issue Jun 5, 2024 · 0 comments · Fixed by #3505
Closed

[Product] Thumbnails not updating the active media #3502

ludoboludo opened this issue Jun 5, 2024 · 0 comments · Fixed by #3505
Assignees
Labels
Category: Bug Something isn't working

Comments

@ludoboludo
Copy link
Contributor

ludoboludo commented Jun 5, 2024

Describe the current behavior

When you have your product medias set to thumbnails/thumbnails slider, when you select a different variant with a feat. image tied to it, it doesn't update the thumbnails to reflect that change.
Recording

Describe the expected behavior

The thumbnails should be update to reflect the active media shown

Version information (Dawn, browsers and operating systems)

  • Dawn Version: 14
  • Chrome Version 108.0.5359.124
  • macOS Version 13.1

Possible solution

This bit was removed from setActiveMedia() (here) and could be re added within it:

         if (this.elements.thumbnails) {
            const activeThumbnail = this.elements.thumbnails.querySelector(`[data-target="${mediaId}"]`);
            activeThumbnail.parentElement.prepend(activeThumbnail);
          }

Additional context/screenshots

Recording

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants