Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Pricing: Variant option combination that doesn't exist 'Unavailable' product still shows 'Volume pricing available', etc #2870

Closed
Tracked by #2784
edmund-teh opened this issue Jul 18, 2023 · 1 comment · Fixed by #2889
Assignees
Labels
Category: Bug Something isn't working

Comments

@edmund-teh
Copy link

edmund-teh commented Jul 18, 2023

I believe we originally have this issue to avoid layout shift, but it might not make sense to display the Volume pricing available string and the Volume pricing table on a variant combination that doesn't exist.

The information shouldn't display here, as the product is not available and therefore wouldn’t have or shouldn’t have volume pricing available, since the product is unavailable.

See video recording for more info: https://screenshot.click/Volume-pricing-bug-Fast-follow-Jul-18-2023.mp4

https://screenshot.click/Current-PR-Desktop-Unavailable-variant-combo-v2.png
https://screenshot.click/Current-PR-Mobile-Unavailable-variant-combo-v2.png

We are presently doing this in our latest/current version of Dawn, by hiding the Price block on unavailable products/ variant combinations that don't exist: https://screenshot.click/Current-Dawn-Price-block-hidden.png

Image
Image

@edmund-teh edmund-teh added the Category: Bug Something isn't working label Jul 18, 2023
@eugenekasimov eugenekasimov self-assigned this Jul 20, 2023
@sofiamatulis
Copy link
Contributor

We should also do this here: https://screenshot.click/21-01-iv2cu-f8a7r.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants