Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvParams vs __init__ kwargs #88

Open
adzcai opened this issue Feb 23, 2025 · 0 comments
Open

EnvParams vs __init__ kwargs #88

adzcai opened this issue Feb 23, 2025 · 0 comments

Comments

@adzcai
Copy link

adzcai commented Feb 23, 2025

Why is there a distinction between EnvParams and __init__ keyword arguments? I understand __init__ keyword arguments are used for settings that are never modified after instantiation. But the distinction seems arbitrary. I think it would be better to eliminate __init__ keyword arguments entirely and store all "static" configuration inside EnvParams. This is both simpler and more flexible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant