Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Chat tab does not get notified on receiving a message #299

Closed
hboetes opened this issue Jun 16, 2020 · 10 comments
Closed

Private Chat tab does not get notified on receiving a message #299

hboetes opened this issue Jun 16, 2020 · 10 comments
Labels

Comments

@hboetes
Copy link
Member

hboetes commented Jun 16, 2020

Someone sent me a PM and I noticed only much later because the Private Chat tab didn't get a notification message. So no blue bird on the Private chat tab.

@hboetes hboetes added the bug label Jun 16, 2020
@mathiascode
Copy link
Member

Can you reproduce this, or did it only happen once? A light bulb icon should appear on the private chat tab if you get a new message.

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

It happened multiple times. I'll send you my username via the mail, so we can test it.

The lightbulb appeared on the user tab in private chat, but not on the private chat tab

@mathiascode
Copy link
Member

I tested sending messages with three different clients, and I consistently got a notification icon on the tab.

@zniavre
Copy link
Contributor

zniavre commented Jun 16, 2020

same here on individual tabsit's ok but the "private chat" tab did not
first line of tabs hav strange behavior (private and download, as i believed few days ago)

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

Well that's odd. This time it worked. Next time I'll pay close attention to the circumstances and ask the messenger for details.

Please don't close this bug yet.

@zniavre
Copy link
Contributor

zniavre commented Jun 16, 2020

i guess if nic+ is focused it works but if you leave it in background it does not

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

@zniavre I couldn't reproduce that. Are you running the latest git version?

@hboetes
Copy link
Member Author

hboetes commented Jun 16, 2020

The leech plugin does send a message, I can understand this does not trigger a notice in the private chat tab, it would be nice though.

I recall clicking on the private chat tab, noticing a message was sent to a user not sharing files, the user replied saying he was rescanning. Both events did not trigger a notice on the private chat tab.
If someone is willing to try to reproduce this problem, please find me in the nicotine-dev channel.

@mathiascode
Copy link
Member

mathiascode commented Jun 16, 2020

There's no special filtering for leech messages though, it's just a normal message that is supposed to trigger a notification as usual.

Edit: Sorry, I misunderstood. Outgoing leech messages don't trigger any notifications currently, no.

@hboetes
Copy link
Member Author

hboetes commented Jun 17, 2020

I just had someone who didn't share who replied to the auto-message and I got notified of that. Closing.

@hboetes hboetes closed this as completed Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants