Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all configs optional #407

Open
1 task done
kkomelin opened this issue Feb 20, 2025 · 4 comments
Open
1 task done

Make all configs optional #407

kkomelin opened this issue Feb 20, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@kkomelin
Copy link

kkomelin commented Feb 20, 2025

Description

Walrus config and walrus site builder config should not be compulsory. Just hardcode the package value for them in the code of walrus and site-builder. Users don't need them. Otherwise we constantly need to compare our values with the documentation, why?

Component

site-builder

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@kkomelin kkomelin added the enhancement New feature or request label Feb 20, 2025
@kkomelin kkomelin changed the title Let's make all those configs optional Make all configs optional Feb 21, 2025
@gordonkoehn
Copy link

gordonkoehn commented Mar 5, 2025

Finding this package id is not a great Development Experience to get started. Took me a minute to find it in sites-config.yaml.

@kkomelin
Copy link
Author

kkomelin commented Mar 5, 2025

@gordonkoehn It's in the documentation but still https://docs.walrus.site/walrus-sites/tutorial-install.html#configuration

@gordonkoehn
Copy link

Appreciated – realized just also now. Should have read to the end of the page. 😅 Apologies for unnecessarily adding to this thread.

@kkomelin
Copy link
Author

kkomelin commented Mar 5, 2025

@gordonkoehn No, no, your feedback is very appropriate. Thank you. It just confirms my point. There should be default configuration added to the site-builder itself without the need to create the configuration file manually after installation. Who knows that package ID value better than the site-builder developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants