From 527e7256f48828dc083f2a194d20efd67ee8e418 Mon Sep 17 00:00:00 2001
From: kyle-ssg <kyle@solidstategroup.com>
Date: Wed, 16 Oct 2024 11:11:21 +0100
Subject: [PATCH 1/3] Combine segment override and value change requests

---
 frontend/web/components/modals/AssociatedSegmentOverrides.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/web/components/modals/AssociatedSegmentOverrides.js b/frontend/web/components/modals/AssociatedSegmentOverrides.js
index 390f94d0ba45..b4ed8e69daff 100644
--- a/frontend/web/components/modals/AssociatedSegmentOverrides.js
+++ b/frontend/web/components/modals/AssociatedSegmentOverrides.js
@@ -333,7 +333,7 @@ export default class SegmentOverridesInner extends Component {
           })
           const segmentOverride =
             segmentOverrides && segmentOverrides.filter((v) => v.segment === id)
-          if (!segmentOverrides) return null
+          if (!segmentOverride?.length) return null
           return (
             <div>
               {originalSegmentOverrides.length > 1 && (

From fef47a4bd30b276d178427dfaded890a16e63664 Mon Sep 17 00:00:00 2001
From: kyle-ssg <kyle@solidstategroup.com>
Date: Wed, 16 Oct 2024 11:15:43 +0100
Subject: [PATCH 2/3] Remove unused code

---
 .../web/components/modals/AssociatedSegmentOverrides.js     | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/frontend/web/components/modals/AssociatedSegmentOverrides.js b/frontend/web/components/modals/AssociatedSegmentOverrides.js
index b4ed8e69daff..282e5781d675 100644
--- a/frontend/web/components/modals/AssociatedSegmentOverrides.js
+++ b/frontend/web/components/modals/AssociatedSegmentOverrides.js
@@ -177,11 +177,7 @@ class TheComponent extends Component {
             }
             renderRow={(v) => (
               <div key={v.feature.id} className='list-item-override p-3 mb-4'>
-                <div
-                  onClick={() => {
-                    // window.open(`${document.location.origin}/project/${this.props.projectId}/environment/${v.env.api_key}/features?feature=${v.feature.id}&tab=1`)
-                  }}
-                >
+                <div>
                   <WrappedSegmentOverrides
                     onSave={this.fetch}
                     projectFlag={v.feature}

From 95d9b2f6a0110d5d5a6c2859d823ff84463ea6b5 Mon Sep 17 00:00:00 2001
From: kyle-ssg <kyle@solidstategroup.com>
Date: Wed, 16 Oct 2024 11:17:59 +0100
Subject: [PATCH 3/3] Neaten code

---
 frontend/web/components/modals/AssociatedSegmentOverrides.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/frontend/web/components/modals/AssociatedSegmentOverrides.js b/frontend/web/components/modals/AssociatedSegmentOverrides.js
index 282e5781d675..06f48deb5c47 100644
--- a/frontend/web/components/modals/AssociatedSegmentOverrides.js
+++ b/frontend/web/components/modals/AssociatedSegmentOverrides.js
@@ -327,8 +327,9 @@ export default class SegmentOverridesInner extends Component {
               )
             this.setState({ isSaving: true })
           })
-          const segmentOverride =
-            segmentOverrides && segmentOverrides.filter((v) => v.segment === id)
+          const segmentOverride = segmentOverrides?.filter?.(
+            (v) => v.segment === id,
+          )
           if (!segmentOverride?.length) return null
           return (
             <div>