Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Some tasks are not being initialised #5213

Merged
merged 7 commits into from
Mar 11, 2025
Merged

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 11, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #5209.

To make sure all the tasks are properly registered, relies on autodiscovery added in Flagsmith/flagsmith-task-processor#27 and moves all existing tasks to tasks.py modules.

How did you test this code?

Ran python manage.py runprocessor from a built Private Cloud image and made sure all of the missing tasks are present in the debug output.

@khvn26 khvn26 requested a review from a team as a code owner March 11, 2025 13:20
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team March 11, 2025 13:20
Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 2:48pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 2:48pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 2:48pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5213 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5213 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5213 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5213 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5213 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5213 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Mar 11, 2025

Uffizzi Preview deployment-61777 was deleted.

@github-actions github-actions bot added fix and removed fix labels Mar 11, 2025
@khvn26 khvn26 requested a review from matthewelwell March 11, 2025 13:25
@github-actions github-actions bot added fix and removed fix labels Mar 11, 2025
@github-actions github-actions bot added fix and removed fix labels Mar 11, 2025
@github-actions github-actions bot added fix and removed fix labels Mar 11, 2025
@github-actions github-actions bot added fix and removed fix labels Mar 11, 2025
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.51%. Comparing base (0fed1d6) to head (83bb9d0).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5213      +/-   ##
==========================================
+ Coverage   97.50%   97.51%   +0.01%     
==========================================
  Files        1224     1227       +3     
  Lines       42623    42619       -4     
==========================================
+ Hits        41558    41559       +1     
+ Misses       1065     1060       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit e8b203b into main Mar 11, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/tasks-not-initialised branch March 11, 2025 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some tasks are not being initialised
2 participants