Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): E2E builds Docker images unneccessarily on publish #5212

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Mar 11, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

As seen here, the E2E job starts building a Core API Docker image because it fails to pull the already built private cloud image.

The fix is to pass required tokens explicitly so the job is properly authorised to pull the already built image.

How did you test this code?

This is a CI change.

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Mar 11, 2025 0:26am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Mar 11, 2025 0:26am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Mar 11, 2025 0:26am

@github-actions github-actions bot added the fix label Mar 11, 2025
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5212 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5212 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5212 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5212 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5212 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5212 Finished ✅ Results

@khvn26 khvn26 requested a review from matthewelwell March 11, 2025 12:27
Copy link
Contributor

github-actions bot commented Mar 11, 2025

Uffizzi Preview deployment-61772 was deleted.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (0fed1d6) to head (a188661).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5212   +/-   ##
=======================================
  Coverage   97.50%   97.50%           
=======================================
  Files        1224     1224           
  Lines       42623    42623           
=======================================
  Hits        41558    41558           
  Misses       1065     1065           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@khvn26 khvn26 merged commit ba0610e into main Mar 11, 2025
38 checks passed
@khvn26 khvn26 deleted the fix/ci-publish-e2e-builds-docker-unneccessarily branch March 11, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants