Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use consistent button style for SSO login actions #5202

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

rolodato
Copy link
Member

Currently, the "Single Sign-On" button for login has a different style than the rest. Some customers misunderstood this style to mean that SSO is "selected" and that they should type their email address in the form below:

image

This PR changes it so that "Single Sign-On" uses the same style as the GitHub and Google login options, and corrects the CTA wording to "Log in". "Login" is a noun, not a verb.

image

@rolodato rolodato requested a review from a team as a code owner March 10, 2025 13:57
@rolodato rolodato requested review from tiagoapolo and removed request for a team March 10, 2025 13:57
Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:00pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 2:00pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Mar 10, 2025 2:00pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Mar 10, 2025
Copy link
Contributor

github-actions bot commented Mar 10, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5202 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5202 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5202 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5202 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5202 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5202 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Mar 10, 2025

Uffizzi Preview deployment-61716 was deleted.

@rolodato rolodato merged commit 3bd4dfd into main Mar 10, 2025
33 checks passed
@rolodato rolodato deleted the fix/sso-button-colour branch March 10, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants