Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix Docker Compose healthcheck #5198

Merged
merged 1 commit into from
Mar 7, 2025
Merged

fix: Fix Docker Compose healthcheck #5198

merged 1 commit into from
Mar 7, 2025

Conversation

rolodato
Copy link
Member

@rolodato rolodato commented Mar 7, 2025

Fixes #5197.

Docker Compose depends_on with condition: service_healthy only looks at the healthcheck defined in Compose, and not the HEALTHCHECK defined in the Dockerfile.

Several alternatives to fix this:

  • Duplicate the current HEALTHCHECK into healthcheck
  • Remove the current HEALTHCHECK and only use healthcheck
  • Ignore health in Docker Compose and only use startup dependencies. I chose this since it avoids duplicating healthcheck logic while still letting us detect container health outside of Compose, and it's closer to how production-ready deployments work (e.g. Kubernetes, which doesn't let you specify service dependencies by design)

Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Mar 7, 2025 4:08pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Mar 7, 2025 4:08pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Mar 7, 2025 4:08pm

@github-actions github-actions bot added the fix label Mar 7, 2025
Copy link
Contributor

github-actions bot commented Mar 7, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5198 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5198 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5198 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5198 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5198 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5198 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Mar 7, 2025

Uffizzi Preview deployment-61655 was deleted.

@khvn26 khvn26 merged commit 5f611b5 into main Mar 7, 2025
33 checks passed
@khvn26 khvn26 deleted the fix/compose-healthcheck branch March 7, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants