Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Try out amplitude engagement SDK #5164

Merged
merged 1 commit into from
Mar 4, 2025
Merged

feat: Try out amplitude engagement SDK #5164

merged 1 commit into from
Mar 4, 2025

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

@kyle-ssg kyle-ssg requested a review from a team as a code owner February 27, 2025 10:14
@kyle-ssg kyle-ssg requested review from tiagoapolo and removed request for a team February 27, 2025 10:14
@vercel Vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:25am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 10:25am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 27, 2025 10:25am

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard feature New feature or request labels Feb 27, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5164 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5164 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-e2e:pr-5164 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith:pr-5164 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5164 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5164 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 27, 2025 •
edited
Loading

Uffizzi Preview deployment-61399 was deleted.

matthewelwell
matthewelwell reviewed Mar 4, 2025
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we wrap this in a flag to be safe?

@kyle-ssg kyle-ssg merged commit e348826 into main Mar 4, 2025
33 checks passed
@kyle-ssg kyle-ssg deleted the feat/amplitude-engagement-sdk branch March 4, 2025 09:50
@flagsmithdev flagsmithdev mentioned this pull request Mar 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell left review comments

@tiagoapolo tiagoapolo tiagoapolo approved these changes

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kyle-ssg @tiagoapolo @matthewelwell