Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix StaleFlagWarning Display & Migrate FeatureRow to TypeScript #5129

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

tiagoapolo
Copy link
Contributor

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This PR fixes the issue where StaleFlagWarning appears even when no protected tags exist for a feature.

  • Migrates FeatureRow to typescript
  • Fixes the environmentFlags field in FeatureListProviderData.
  • Unifies the environmentFlags type by deriving it from FeatureListProviderData.
  • converts getProtectedFlags into a hook (useProtectedTags)
  • Removes incorrect props passed to FeatureRow

How did you test this code?

Tested manually by checking all instances of FeatureRow

@tiagoapolo tiagoapolo requested a review from a team as a code owner February 18, 2025 19:53
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 18, 2025 19:53
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:20am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 10:20am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 10:20am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 18, 2025
@tiagoapolo tiagoapolo self-assigned this Feb 18, 2025
@github-actions github-actions bot added the feature New feature or request label Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5129 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5129 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5129 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5129 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5129 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5129 Finished ✅ Results

@tiagoapolo tiagoapolo changed the title feat: Fix stale flag warning not updating feat: Fix StaleFlagWarning Display & Migrate FeatureRow to TypeScript Feb 18, 2025
@tiagoapolo tiagoapolo changed the title feat: Fix StaleFlagWarning Display & Migrate FeatureRow to TypeScript fix: Fix StaleFlagWarning Display & Migrate FeatureRow to TypeScript Feb 18, 2025
@tiagoapolo tiagoapolo force-pushed the fix/stale-flag-warning branch from ff68d75 to 33aa768 Compare February 18, 2025 19:55
@github-actions github-actions bot added fix and removed feature New feature or request labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Uffizzi Preview deployment-61072 was deleted.

@kyle-ssg
Copy link
Member

Nice!

Copy link

sentry-io bot commented Feb 24, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ SyntaxError: JSON.parse: expected ':' after property name in object at line 1 column 73 of the JSON data Utils.fromParam(common/utils/base/_utils) View Issue
  • ‼️ SyntaxError: JSON.parse: expected ':' after property name in object at line 1 column 73 of the JSON data Utils.fromParam(common/utils/base/_utils) View Issue
  • ‼️ SecurityError: Failed to read the 'localStorage' property from 'Window': Access is denied for this document. new Promise(<anonymous>) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants