Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Audit Log integrations are triggered when integration config is soft deleted #5128

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 18, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes #5127.

How did you test this code?

Added a test that reproduces the problem.

@khvn26 khvn26 requested a review from a team as a code owner February 18, 2025 18:28
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team February 18, 2025 18:28
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 6:59pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 6:59pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 6:59pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5128 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5128 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5128 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5128 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5128 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5128 Finished ✅ Results

@github-actions github-actions bot added fix and removed fix labels Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Uffizzi Preview deployment-61063 was deleted.

@github-actions github-actions bot added fix and removed fix labels Feb 18, 2025
@github-actions github-actions bot added fix and removed fix labels Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (5de0b42) to head (273ad8b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5128   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files        1216     1216           
  Lines       42368    42376    +8     
=======================================
+ Hits        41289    41297    +8     
  Misses       1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit a81d22e into main Feb 18, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/audit-log-integrations-soft-deleted branch February 18, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit Log integrations are triggered when integration config is soft deleted
2 participants