Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Add missing type stubs for dependencies #5126

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 18, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds a bunch of type stubs for dependencies and removes corresponding type: ignore comments for their imports.

How did you test this code?

Verified the typecheck passes.

@khvn26 khvn26 requested a review from a team as a code owner February 18, 2025 15:08
@khvn26 khvn26 requested review from matthewelwell and removed request for a team February 18, 2025 15:08
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 18, 2025 3:08pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Feb 18, 2025 3:08pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Feb 18, 2025 3:08pm

@github-actions github-actions bot added the api Issue related to the REST API label Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5126 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5126 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5126 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5126 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5126 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5126 Finished ✅ Results

@github-actions github-actions bot added the fix label Feb 18, 2025
Copy link
Contributor

github-actions bot commented Feb 18, 2025

Uffizzi Preview deployment-61055 was deleted.

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.45%. Comparing base (5de0b42) to head (05d7d9f).
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5126   +/-   ##
=======================================
  Coverage   97.45%   97.45%           
=======================================
  Files        1216     1216           
  Lines       42368    42368           
=======================================
  Hits        41289    41289           
  Misses       1079     1079           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 merged commit 4e1ba8b into main Feb 19, 2025
37 checks passed
@khvn26 khvn26 deleted the fix/add-type-stubs-for-deps branch February 19, 2025 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants