Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dynamically update theme toggle tooltip text based on current mode #5117

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

Dcode2100
Copy link
Contributor

@Dcode2100 Dcode2100 commented Feb 17, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Bug - Before the change: The tooltip always displayed 'Dark Mode' regardless of the current theme
image

Please describe.

I have updated the internal logic to dynamically display 'Light Mode' or 'Dark Mode' based on the current theme.

How did you test this code?

Manually tested by:

  1. Switching between light/dark modes
  2. Verifying Tooltip text updates correctly
  1. Hover over the theme toggle button located at the top-right corner of any page.
    Please describe.

@Dcode2100 Dcode2100 requested a review from a team as a code owner February 17, 2025 17:31
@Dcode2100 Dcode2100 requested review from tiagoapolo and removed request for a team February 17, 2025 17:31
Copy link

vercel bot commented Feb 17, 2025

Someone is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 5:32pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Feb 17, 2025
@Dcode2100 Dcode2100 changed the title fix: Dynamically update theme toggle text based on current mode fix: Dynamically update theme toggle tooltip text based on current mode Feb 17, 2025
@kyle-ssg
Copy link
Member

Thanks for the contribution! 🚀

@kyle-ssg kyle-ssg merged commit e2e2f52 into Flagsmith:main Feb 18, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants