Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adds margin to saml tab #5104

Merged
merged 1 commit into from
Feb 14, 2025
Merged

fix: adds margin to saml tab #5104

merged 1 commit into from
Feb 14, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Feb 13, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

BEFORE
Screenshot 2025-02-13 at 11 49 24

AFTER
Screenshot 2025-02-13 at 11 48 38

When PlanBasedBanner matches hasPlan condition no margin is added to Saml Tab content. In order to fix that and not have an impact in other places that use PlanBasedBanner a div wrapping Sam tab content was added to add margin top and bottom being consistent with all other tabs spacings

How did you test this code?

Open saml tab configuration validate if margin is added

@tiagoapolo tiagoapolo requested a review from a team as a code owner February 13, 2025 14:56
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team February 13, 2025 14:56
@vercel Vercel
Copy link

vercel bot commented Feb 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:57pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 2:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 13, 2025 2:57pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5104 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5104 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5104 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-5104 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-5104 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5104 Finished ✅ Results ✅

@tiagoapolo tiagoapolo self-assigned this Feb 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 13, 2025 •
edited
Loading

Uffizzi Preview deployment-60896 was deleted.

@tiagoapolo tiagoapolo merged commit 6cffced into main Feb 14, 2025
33 checks passed
@tiagoapolo tiagoapolo deleted the fix/saml-tab-margin branch February 14, 2025 14:33
@flagsmithdev flagsmithdev mentioned this pull request Feb 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees

@tiagoapolo tiagoapolo

Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tiagoapolo @matthewelwell