Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert modal on Identity page incorrectly uses title case #5076

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

matthewelwell
Copy link
Contributor

Changes

Overrides the text-transform value set by any parent to ensure that the content is not modified incorrectly. For example, since the alert on the identity page is in the panel header section, it is inheriting text-transform: capitalize from it's styling.

Before:

image

After:

image

How did you test this code?

Verified that the problematic alert was fixed, and that others remained unaffected.

@matthewelwell matthewelwell requested a review from a team as a code owner February 5, 2025 15:43
@matthewelwell matthewelwell requested review from tiagoapolo and removed request for a team February 5, 2025 15:43
Copy link

vercel bot commented Feb 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2025 3:43pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Feb 5, 2025 3:43pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5076 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5076 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5076 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5076 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5076 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5076 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Uffizzi Preview deployment-60646 was deleted.

@matthewelwell matthewelwell merged commit 88fef8d into main Feb 10, 2025
33 checks passed
@matthewelwell matthewelwell deleted the fix/text-transform-alert branch February 10, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants