Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Health provider not accessible by name in API #5075

Merged
merged 3 commits into from
Feb 4, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Feb 4, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Please describe.

How did you test this code?

Please describe.

@khvn26 khvn26 requested a review from a team as a code owner February 4, 2025 07:54
@khvn26 khvn26 requested review from matthewelwell and removed request for a team February 4, 2025 07:54
Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 0:02am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 0:02am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 0:02am

@github-actions github-actions bot added api Issue related to the REST API fix labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5075 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5075 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5075 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5075 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5075 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5075 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Uffizzi Preview deployment-60588 was deleted.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.43%. Comparing base (d4c4aaa) to head (263512b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5075   +/-   ##
=======================================
  Coverage   97.43%   97.43%           
=======================================
  Files        1214     1214           
  Lines       42267    42277   +10     
=======================================
+ Hits        41183    41193   +10     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added fix and removed fix labels Feb 4, 2025
@github-actions github-actions bot added fix and removed fix labels Feb 4, 2025
@khvn26 khvn26 merged commit 88e5ab9 into main Feb 4, 2025
35 checks passed
@khvn26 khvn26 deleted the fix/health-provider-name-lookup branch February 4, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants