Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cast boolean on length environment #5017

Merged

Conversation

Zaimwa9
Copy link
Contributor

@Zaimwa9 Zaimwa9 commented Jan 20, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Low hanging fruit.

Reviewed rendering condition of the clone from environment input which displays a "0"

How did you test this code?

Before
image

After
image
image

@Zaimwa9 Zaimwa9 requested a review from a team as a code owner January 20, 2025 13:58
@Zaimwa9 Zaimwa9 requested review from kyle-ssg and removed request for a team January 20, 2025 13:58
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 3:23pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 3:23pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 3:23pm

Copy link

vercel bot commented Jan 20, 2025

@Zaimwa9 is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 20, 2025
@matthewelwell matthewelwell changed the title Fix: cast-boolean-on-length-environment fix: cast boolean on length environment Jan 20, 2025
Copy link
Contributor

github-actions bot commented Jan 20, 2025

Uffizzi Preview deployment-60065 was deleted.

Copy link
Contributor

@tiagoapolo tiagoapolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tiagoapolo tiagoapolo merged commit c0e8b81 into Flagsmith:main Jan 22, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants