Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove AWS IMDS endpoint request on API startup #5008

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Flagsmith always performs a request to the AWS Instance Metadata Service (IMDS) on startup, whether it is running on AWS or not. This was presumably used in an older infrastructure configuration which is no longer required.

How did you test this code?

Not tested - going to validate this in staging.

@rolodato rolodato requested a review from a team as a code owner January 16, 2025 15:14
@rolodato rolodato requested review from gagantrivedi and removed request for a team January 16, 2025 15:14
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 16, 2025 3:14pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 16, 2025 3:14pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 16, 2025 3:14pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 16, 2025
Copy link
Contributor

github-actions bot commented Jan 16, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-5008 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-5008 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-5008 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-5008 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5008 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5008 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 16, 2025

Uffizzi Preview deployment-59989 was deleted.

@rolodato rolodato merged commit 2e79ff4 into main Jan 16, 2025
36 checks passed
@rolodato rolodato deleted the fix/metadata-request-on-startup branch January 16, 2025 15:55
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (2fe4e02) to head (5405974).
Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5008   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41630    41626    -4     
=======================================
- Hits        40546    40543    -3     
+ Misses       1084     1083    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants