fix: Don't display password managers on irrelevant input fields #5004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
front-end
Docker builds report
|
|
Uffizzi Preview |
|
This is great! |
tiagoapolo
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
All Input components by default have
one-time-codeautocomplete. This causes password managers such as 1Password to display a prompt on all kinds of inputs where it makes no sense and is annoying:This change removes this default.
The only place where
one-time-codeshould be used is in the MFA code input, which is added by this change:Note that at MFA autocomplete still works (at least in 1Password) without setting
autocomplete=one-time-code.Lastly, this change also sets explicit
autocompletevalues for changing passwords. These also still work in 1Password currently, but is good practice to have them.How did you test this code?
Manually tested different input fields in the frontend.