Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Action dropdown not properly overflowing #5000

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 14, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

ref: #4981
Because virtualized lists require an overflow, it requires a react portal to render the dropdown outside of the overflow context.

Single user
Screenshot 2025-01-14 at 15 25 35

[multiple users] user positioned in the middle of the scrollable container
Screenshot 2025-01-14 at 15 26 01

[multiple users] user positioned in the bottom of the scrollable container
Screenshot 2025-01-14 at 15 26 06

How did you test this code?

  1. go to /organisation/<ORG_ID>/permissions
  2. Make sure you have a members list with 100+ users
  3. click on 3 dots to see actions

@tiagoapolo tiagoapolo requested a review from a team as a code owner January 14, 2025 19:05
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 14, 2025 19:05
Copy link

vercel bot commented Jan 14, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 7:05pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 14, 2025 7:05pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 14, 2025 7:05pm

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Jan 14, 2025
@tiagoapolo tiagoapolo self-assigned this Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-5000 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-5000 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-5000 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-5000 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-5000 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-5000 Finished ✅ Results

@github-actions github-actions bot added the fix label Jan 14, 2025
Copy link
Contributor

github-actions bot commented Jan 14, 2025

Uffizzi Preview deployment-59918 was deleted.

@kyle-ssg
Copy link
Member

Great stuff

@kyle-ssg kyle-ssg merged commit 5fc9fef into main Jan 15, 2025
31 checks passed
@kyle-ssg kyle-ssg deleted the fix/dropdown-overflow--4981 branch January 15, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants