Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds force-2fa to startup plan #4994

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix: Adds force-2fa to startup plan #4994

merged 1 commit into from
Jan 14, 2025

Conversation

tiagoapolo
Copy link
Contributor

@tiagoapolo tiagoapolo commented Jan 13, 2025 •
edited
Loading

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Ref: #4954
Adds FORCE_2FA to startup plan, moving 2FA from individual level to organisation level
Screenshot 2025-01-13 at 16 59 46

How did you test this code?

  1. Go to /organisation/<ORG_ID>/settings?tab=general using an org on startup plan
  2. Check if Force 2FA setting is available

@tiagoapolo tiagoapolo requested a review from a team as a code owner January 13, 2025 20:14
@tiagoapolo tiagoapolo requested review from kyle-ssg and removed request for a team January 13, 2025 20:14
@tiagoapolo tiagoapolo self-assigned this Jan 13, 2025
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:15pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 13, 2025 8:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 13, 2025 8:15pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Jan 13, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4994 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4994 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4994 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4994 Finished ✅ Results ✅

@tiagoapolo tiagoapolo requested review from matthewelwell and a team January 13, 2025 20:16
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 13, 2025 •
edited
Loading

Uffizzi Preview deployment-59869 was deleted.

@matthewelwell matthewelwell merged commit d0e2f76 into main Jan 14, 2025
31 checks passed
@matthewelwell matthewelwell deleted the fix/force--2fa branch January 14, 2025 12:02
@flagsmithdev flagsmithdev mentioned this pull request Jan 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyle-ssg kyle-ssg kyle-ssg approved these changes

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees

@tiagoapolo tiagoapolo

Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tiagoapolo @kyle-ssg @matthewelwell