Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use "Flagsmith" as default TOTP issuer #4992

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Updates the default TOTP issuer name to "Flagsmith". This is shown by some authenticator apps to distinguish between TOTP secrets.

How did you test this code?

Tested by reading a locally-generated QR code into a few authenticator apps:

Google Authenticator

IMG_5016

Microsoft Authenticator

IMG_5017

@rolodato rolodato requested a review from a team as a code owner January 13, 2025 13:49
@rolodato rolodato requested review from matthewelwell and removed request for a team January 13, 2025 13:49
Copy link

vercel bot commented Jan 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Jan 13, 2025 1:49pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Jan 13, 2025 1:49pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Jan 13, 2025 1:49pm

@github-actions github-actions bot added api Issue related to the REST API fix labels Jan 13, 2025
Copy link
Contributor

github-actions bot commented Jan 13, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4992 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4992 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4992 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4992 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4992 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4992 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Jan 13, 2025

Uffizzi Preview deployment-59838 was deleted.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (2fe4e02) to head (2873542).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4992   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41630    41633    +3     
=======================================
+ Hits        40546    40549    +3     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 0681988 into main Jan 14, 2025
36 checks passed
@matthewelwell matthewelwell deleted the fix/default-totp-issuer branch January 14, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants