Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): fixes issue exporting identity feature states with missing attributes #4987

Merged

Conversation

matthewelwell
Copy link
Contributor

Changes

This fixes a bug found in the export process for old identities that have overrides with missing "feature_state_value".

How did you test this code?

Updated existing unit test.

@matthewelwell matthewelwell marked this pull request as ready for review January 10, 2025 11:50
@matthewelwell matthewelwell requested a review from a team as a code owner January 10, 2025 11:50
@matthewelwell matthewelwell requested review from gagantrivedi and removed request for a team January 10, 2025 11:50
Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:51am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:51am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 11:51am

@github-actions github-actions bot added the api Issue related to the REST API label Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4987 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4987 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4987 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4987 Finished ✅ Results

@github-actions github-actions bot added the fix label Jan 10, 2025
@github-actions github-actions bot added fix and removed fix labels Jan 10, 2025
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Uffizzi Preview deployment-59760 was deleted.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (2fe4e02) to head (c068349).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4987   +/-   ##
=======================================
  Coverage   97.39%   97.39%           
=======================================
  Files        1191     1191           
  Lines       41630    41633    +3     
=======================================
+ Hits        40546    40549    +3     
  Misses       1084     1084           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matthewelwell matthewelwell merged commit 8cd2731 into main Jan 10, 2025
35 checks passed
@matthewelwell matthewelwell deleted the fix/handle-missing-attributes-in-identities-export branch January 10, 2025 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants