-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improves segment rule value validation and feedback #4975
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Docker builds report
|
Uffizzi Preview |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an improvement, and it works for some use cases. But there are some use cases it doesn't handle very well, e.g. the following:

I guess, if we want to continue with this approach, we can try to add an ellipsis after a certain number of characters or lines?
But in general, I think the above use case is one that we really do want to try and solve for (long lists of e.g. uuids). the only way I can really think of doing it, is having some kind of modal overlay for editing the value, but I know that can be tricky with the UI architecture as it is currently. Perhaps let's discuss with @kyle-ssg when he's back tomorrow.
3ff0cda
to
9d6c582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! I have a feeling this is going to be super helpful for a lot of our customers. It also allows us to add more validation / code highlighting options in the future.
One minor point, is that I'd prefer the icon to look something slightly more like a traditional expand icon (the one in the current implementation looks more like a scroll icon). Something like this would be better, if we can make it work.
- Modify global.d.ts to export closeModal2 method - Adds unfold icon
60187ce
to
3a7394c
Compare
Thanks for submitting a PR! Please check the boxes below:
docs/
if required so people know about the feature!Changes
Ref: #3920
This pull request includes changes to the
Tooltip
component and theRule
component in the frontend. TheTooltip
component has been enhanced with additional properties, while theRule
component now utilizes a newRuleInputValue
component to handle long text editing in a new modal and validates leading and trailing whitespaces(DARK MODE)

(LIGHT MODE)

How did you test this code?
Manually tested