Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support --exclusive-start-key option for ensure_identity_traits_blanks #4941

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jan 2, 2025

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Added an option to retrieve the exclusive start key for the heal identities command from Sentry in case if an exception raised during command runtime. We also allow to start the scanning from an exclusive start key by providing a command argument. Additionally, there's a bit of a refactoring to clearly segregate table scans and table queries.

How did you test this code?

Added unit tests to cover new code.

@khvn26 khvn26 requested a review from a team as a code owner January 2, 2025 10:46
@khvn26 khvn26 requested review from gagantrivedi and removed request for a team January 2, 2025 10:46
Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 10:48am
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 10:48am
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2025 10:48am

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-e2e:pr-4941 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4941 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4941 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4941 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4941 Finished ✅ Results

@github-actions github-actions bot added feature New feature or request and removed feature New feature or request labels Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Uffizzi Preview deployment-59431 was deleted.

@khvn26 khvn26 merged commit 4f71482 into main Jan 2, 2025
31 of 33 checks passed
@khvn26 khvn26 deleted the feat/heal-identities-exclusive-start-key branch January 2, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants