Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide view features from associated segment overrides #4786

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Closes #4740, view segment button is hidden from associated segment overrides.

image

How did you test this code?

Viewed segment from segment overrides, but couldn't from segment modal
image

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 30, 2024 11:46
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:46am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 30, 2024 11:46am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 30, 2024 11:46am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4786 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4786 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4786 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4786 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4786 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4786 Finished ✅ Results

@matthewelwell matthewelwell changed the title Hide view features from associated segment overrides fix: hide view features from associated segment overrides Oct 30, 2024
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Uffizzi Preview deployment-57776 was deleted.

@kyle-ssg kyle-ssg added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit 49ff569 Oct 30, 2024
30 checks passed
@kyle-ssg kyle-ssg deleted the fix/hide-view-segment-from-associated-overrides branch October 30, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Features' tab in a segment shows 'View Segment' option for each override
2 participants