Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: associated segment override check #4781

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: associated segment override check #4781

merged 1 commit into from
Oct 29, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes associated segment override permission checks to use the selected environment.

How did you test this code?

  • As a user with manage segment override permissions on the demo environment but not production we see the following
image image

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 29, 2024 13:28
@vercel Vercel
Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:28pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2024 1:28pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 29, 2024 1:28pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4781 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4781 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4781 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4781 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4781 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4781 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 29, 2024 •
edited
Loading

Uffizzi Preview deployment-57738 was deleted.

@kyle-ssg kyle-ssg linked an issue Oct 29, 2024 that may be closed by this pull request
Users with permissions to manage segments and segment overrides cannot create segment overrides from the Segment #4772
Closed
4 tasks
matthewelwell
matthewelwell approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@matthewelwell matthewelwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested manually - looks good to me.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 85556a0 Oct 29, 2024
31 checks passed
@matthewelwell matthewelwell deleted the fix/associated_segment_override_permissions branch October 29, 2024 14:15
@flagsmithdev flagsmithdev mentioned this pull request Oct 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
2 participants
@kyle-ssg @matthewelwell