Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Flag Defaults settings makes identity flags unusable #4771

Closed
1 of 4 tasks
azriel46d opened this issue Oct 25, 2024 · 1 comment · Fixed by #4809
Closed
1 of 4 tasks

Prevent Flag Defaults settings makes identity flags unusable #4771

azriel46d opened this issue Oct 25, 2024 · 1 comment · Fixed by #4809
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard

Comments

@azriel46d
Copy link
Contributor

How are you running Flagsmith

  • Self Hosted with Docker
  • Self Hosted with Kubernetes
  • SaaS at flagsmith.com
  • Some other way (add details in description below)

Describe the bug

in CreateFlag.js the prevent_flag_defaults is passed as a parameter to the <Value /> component, in which basically the input for hideValue is set to true. This makes an identity override unusable unless this project setting is disabled

Steps To Reproduce

  1. Go to project Settings
  2. Enable Prevent Flag Defaults
  3. Go on an environment
  4. Select a flag
  5. Attempt to override the value for a particular user

Expected behavior

As a user I should still be able to override a flag for a particular identity.

Screenshots

No response

@azriel46d azriel46d added the bug Something isn't working label Oct 25, 2024
@matthewelwell
Copy link
Contributor

Thanks @azriel46d , I have been able to reproduce this, and I am adding the below screenshot to help illustrate the issue.

Image

If you're willing to submit a PR, we'd gratefully receive it - otherwise, we'll look to fix it up as soon as we can.

@matthewelwell matthewelwell added the front-end Issue related to the React Front End Dashboard label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants