Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PREVENT_EMAIL_PASSWORD in backend #4765

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Oct 23, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

This adds a permission class to ensure that the /api/v1/auth/login endpoint can not be used when PREVENT_EMAIL_PASSWORD setting is enabled.

How did you test this code?

Enabled the setting locally and tried to access the /api/v1/auth/login endpoint.

@khvn26 khvn26 requested a review from a team as a code owner October 23, 2024 14:56
@khvn26 khvn26 requested review from matthewelwell and removed request for a team October 23, 2024 14:56
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 23, 2024 2:57pm
flagsmith-frontend-preview ⬜️ Ignored (Inspect) Oct 23, 2024 2:57pm
flagsmith-frontend-staging ⬜️ Ignored (Inspect) Oct 23, 2024 2:57pm

@github-actions github-actions bot added api Issue related to the REST API feature New feature or request labels Oct 23, 2024
Copy link
Contributor

github-actions bot commented Oct 23, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4765 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4765 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4765 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-api:pr-4765 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4765 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4765 Finished ✅ Results

Copy link
Contributor

github-actions bot commented Oct 23, 2024

Uffizzi Preview deployment-57558 was deleted.

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (6d2ab58) to head (9d662ae).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4765   +/-   ##
=======================================
  Coverage   97.21%   97.22%           
=======================================
  Files        1172     1172           
  Lines       40535    40537    +2     
=======================================
+ Hits        39408    39411    +3     
+ Misses       1127     1126    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@khvn26 khvn26 added this pull request to the merge queue Oct 23, 2024
Merged via the queue into main with commit 7a6b2e0 Oct 23, 2024
35 checks passed
@khvn26 khvn26 deleted the feat/support-prevent-email-password-in-backend branch October 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants