Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix "assigned groups" showing empty when trying to assign groups to a role #4756

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

rolodato
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

When the API and FE are running on the same domain, the FE tries to hit /my-groups which is not a valid API endpoint. This causes the "Assigned groups" dropdown to show as empty:

image

This change adds the missing trailing slash, which makes this work:

image

How did you test this code?

Manually by running the FE locally against the API on the same domain.

@rolodato rolodato requested a review from a team as a code owner October 22, 2024 12:36
@rolodato rolodato requested review from kyle-ssg and removed request for a team October 22, 2024 12:36
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:36am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 0:36am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 22, 2024 0:36am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4756 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4756 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4756 Finished ✅ Results
ghcr.io/flagsmith/flagsmith:pr-4756 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4756 Finished ✅ Results
ghcr.io/flagsmith/flagsmith-frontend:pr-4756 Finished ✅ Results

@github-actions github-actions bot added the fix label Oct 22, 2024
Copy link
Contributor

github-actions bot commented Oct 22, 2024

Uffizzi Preview deployment-57504 was deleted.

@rolodato rolodato added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 038a15a Oct 22, 2024
31 checks passed
@rolodato rolodato deleted the fix/my-groups-trailing-slash branch October 22, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants