Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: value editor typing #4748

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: value editor typing #4748

merged 1 commit into from
Oct 18, 2024

Conversation

kyle-ssg
Copy link
Member

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

Fixes test attribute causing typing de-focus

How did you test this code?

Attempt to add multivartiate feature values

@kyle-ssg kyle-ssg requested a review from a team as a code owner October 18, 2024 13:29
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 1:31pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 1:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 18, 2024 1:31pm

@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard fix labels Oct 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4748 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4748 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4748 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4748 Finished ✅ Results ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 18, 2024 •
edited
Loading

Uffizzi Preview deployment-57404 was deleted.

@rolodato rolodato added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 99876ca Oct 18, 2024
31 checks passed
@rolodato rolodato deleted the fix/value-editor-typing branch October 18, 2024 13:53
@flagsmithdev flagsmithdev mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolodato rolodato rolodato approved these changes

Assignees
No one assigned
Labels
fix front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyle-ssg @rolodato