Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add trailing slash to endpoint to retrieve features after feature create #4730

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: add trailing slash to endpoint to retrieve features after feature create #4730

merged 1 commit into from
Oct 15, 2024

Conversation

matthewelwell
Copy link
Contributor

Changes

Adds trailing slash to features endpoint following create feature.

How did you test this code?

N/a - trivial change.

@matthewelwell matthewelwell requested a review from a team as a code owner October 15, 2024 12:16
@matthewelwell matthewelwell requested review from kyle-ssg and removed request for a team October 15, 2024 12:16
@vercel Vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 0:17am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 0:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Oct 15, 2024 0:17am

@github-actions github-actions bot added the front-end Issue related to the React Front End Dashboard label Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4730 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4730 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4730 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4730 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4730 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4730 Finished ✅ Results ✅

@matthewelwell matthewelwell changed the title Add trailing slash fix: add trailing slash to endpoint to retrieve features after feature create Oct 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

Uffizzi Preview deployment-57263 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit cbd08f3 Oct 15, 2024
31 checks passed
@matthewelwell matthewelwell deleted the fix/add-trailing-slash-to-features-endpoint branch October 15, 2024 12:26
@flagsmithdev flagsmithdev mentioned this pull request Oct 15, 2024
Merged
matthewelwell added a commit that referenced this pull request Oct 15, 2024
@matthewelwell
fix: add trailing slash to endpoint to retrieve features after featur…
1c4b880 
…e create (#4730)

(cherry picked from commit cbd08f3)
matthewelwell added a commit that referenced this pull request Oct 16, 2024
@matthewelwell
fix: add trailing slash to endpoint to retrieve features after featur…
9be7d1a 
…e create (#4730)

(cherry picked from commit cbd08f3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gagantrivedi gagantrivedi gagantrivedi approved these changes

@kyle-ssg kyle-ssg Awaiting requested review from kyle-ssg kyle-ssg is a code owner automatically assigned from Flagsmith/flagsmith-front-end

Assignees
No one assigned
Labels
front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewelwell @gagantrivedi