Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Hide change email when auth_type !== 'EMAIL' #4712

Merged
merged 3 commits into from
Oct 11, 2024
Merged

feat: Hide change email when auth_type !== 'EMAIL' #4712

merged 3 commits into from
Oct 11, 2024

Conversation

kyle-ssg
Copy link
Member

@kyle-ssg kyle-ssg commented Oct 9, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Documents PREVENT_EMAIL_PASSWORD
  • Hide the change email functionality when AccountStore.model.auth_type !== 'EMAIL'

How did you test this code?

Please describe.

@vercel Vercel
Copy link

vercel bot commented Oct 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:56pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 9, 2024 2:56pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
docs ⬜️ Ignored (Inspect) Visit Preview Oct 9, 2024 2:56pm

@kyle-ssg kyle-ssg requested review from a team as code owners October 9, 2024 14:52
@kyle-ssg kyle-ssg requested review from matthewelwell and removed request for a team October 9, 2024 14:52
@github-actions github-actions bot added front-end Issue related to the React Front End Dashboard docs Documentation updates feature New feature or request and removed docs Documentation updates labels Oct 9, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api-test:pr-4712 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-e2e:pr-4712 Finished ✅ Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4712 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4712 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith:pr-4712 Finished ✅ Results ✅
ghcr.io/flagsmith/flagsmith-frontend:pr-4712 Finished ✅ Results ✅

@kyle-ssg kyle-ssg changed the title feat: Hide change email when PREVENT_EMAIL_PASSWORD is enabled feat: Hide change email when auth_type !== 'EMAIL' Oct 9, 2024
@kyle-ssg kyle-ssg linked an issue Oct 9, 2024 that may be closed by this pull request
UI: Allow org admin to hide change email and change password #4660
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024 •
edited
Loading

Uffizzi Preview deployment-57085 was deleted.

@matthewelwell matthewelwell added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 27109fd Oct 11, 2024
32 checks passed
@matthewelwell matthewelwell deleted the feat/prevent_change_email branch October 11, 2024 15:48
@flagsmithdev flagsmithdev mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zachaysan zachaysan zachaysan approved these changes

@matthewelwell matthewelwell Awaiting requested review from matthewelwell matthewelwell is a code owner automatically assigned from Flagsmith/flagsmith-docs

Assignees
No one assigned
Labels
feature New feature or request front-end Issue related to the React Front End Dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: Allow org admin to hide change email and change password
3 participants
@kyle-ssg @zachaysan @matthewelwell