fix: subscription state #4710
Merged
fix: subscription state #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
github-actions
bot
added
the
front-end
Docker builds report
|
|
Uffizzi Preview |
zachaysan
approved these changes
Oct 11, 2024
Comment on lines
+370
to
+375
| try { | ||
| if (res && res.subscription && res.subscription.plan) { | ||
| API.trackEvent(Constants.events.UPGRADE(res.subscription.plan)) | ||
| API.postEvent(res.subscription.plan, 'chargebee') | ||
| } | ||
| } catch (e) {} |
There was a problem hiding this comment.
I don't really love the empty catch here. Can we silently swallow error conditions that we've allowlisted ahead of time?
There was a problem hiding this comment.
This is just in case Analytics tools are broke for whatever reason, in which case we'd still see something in sentry. Just needs to ensure the later more important things happen regardless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
docs/if required so people know about the feature!Changes
Closes #3952
Fixes state when subscription by refreshing the organisations.
How did you test this code?
Subscribed on staging.